Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rare instances where an expanded folder that has children appears empty #37

Open
david-tejada opened this issue Jan 28, 2024 · 0 comments
Labels
blocked bug Something isn't working

Comments

@david-tejada
Copy link
Contributor

On very rare occasions a folder that has children appears empty. This issue is caused by this vscode bug where TreeView reveal creates a race condition with TreeDataProvider#getChildren. I was able to reproduce this issue fairly consistently by moving a file to a folder that is collapsed and then back.

The modifications in PRs #35 and #36 seem to mitigate this bug since they remove unnecessary calls to TreeView.reveal. This bug seems to be scheduled to be fixed soon so I don't think we need to do anything here. If the bug takes too long to be fixed and the changes in the mentioned PRs don't mitigate the bug enough I could try to add some delays after moving a file so that they refresh call in the file watcher has had enough time to complete. I think I should also only call refresh when the parent entry is expanded anyway.

@paul-schaaf paul-schaaf added bug Something isn't working blocked labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants