Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Developer resources > Global CSS variables page no longer exists #4362

Open
sg00dwin opened this issue Oct 31, 2024 · 2 comments · May be fixed by patternfly/patternfly#7268
Open

Bug - Developer resources > Global CSS variables page no longer exists #4362

sg00dwin opened this issue Oct 31, 2024 · 2 comments · May be fixed by patternfly/patternfly#7268
Assignees
Labels
Milestone

Comments

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 31, 2024
@kmcfaul kmcfaul moved this from Needs triage to Ready to assign in PatternFly Issues Nov 6, 2024
@kmcfaul
Copy link
Contributor

kmcfaul commented Nov 6, 2024

All tokens page can be a replacement, but may not be applicable in some cases (remove if so).

@kmcfaul kmcfaul added this to the 2024.Q4 milestone Nov 6, 2024
@edonehoo edonehoo self-assigned this Nov 12, 2024
@edonehoo edonehoo moved this from Ready to assign to Not started in PatternFly Issues Nov 19, 2024
@edonehoo edonehoo moved this from Not started to In Progress in PatternFly Issues Dec 2, 2024
@mcoker
Copy link
Contributor

mcoker commented Jan 10, 2025

This is probably known, but ideally we'd have something simple a user can reference for our breakpoint values. The only one I know of is in our upgrade guide - https://www.patternfly.org/get-started/upgrade/#4.-update-any-pixel-based-logic-for-breakpoints. Currently users will need to search for breakpoint tokens in the all tokens table.

Personally I'd love to see a page that has all of the top-level semantic tokens grouped by concept (breakpoints, box-shadows, spacers, colors, etc) and anchors to each section that we could link to, then the table can be referenced for more info. This would just be a page like you commonly find on design system sites for their token documentation.

Another idea could be to allow URL parameters to be passed to filter the table (like ?filter=breakpoint or ?filter=t--global--breakpoint or even something like ?layer=semantic&search=breakpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants