Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme switcher in masthead to use toggle groups #3733

Closed
Tracked by #144
andrew-ronaldson opened this issue Aug 25, 2023 · 1 comment · Fixed by #3788
Closed
Tracked by #144

Dark theme switcher in masthead to use toggle groups #3733

andrew-ronaldson opened this issue Aug 25, 2023 · 1 comment · Fixed by #3788
Assignees
Milestone

Comments

@andrew-ronaldson
Copy link
Contributor

This is an org followup closing design issue #1270

Describe the enhancement
Design team decided to change from the switch component to the toggle group to see both light and dark options.

Screenshot 2023-08-25 at 9 54 57 AM

The new design implementation uses these icons from fontawesome:
Moon - <i class="fa-solid fa-moon"></i>
Sun - <i class="fa-solid fa-sun"></i>

@andrew-ronaldson
Copy link
Contributor Author

As a followup it would be good to add recommendations to the dark theme docs about using the Toggle group component. Ideally theming should be handled in a products User preferences but if that is not available this option is the preferred solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants