Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar - transparent track #1315

Closed
nicolethoen opened this issue May 29, 2024 · 5 comments
Closed

Scrollbar - transparent track #1315

nicolethoen opened this issue May 29, 2024 · 5 comments
Assignees
Labels
PatternFly 6 Design issues related to Penta work
Milestone

Comments

@nicolethoen
Copy link
Contributor

The corners of the scroll bar look odd beside the rounded corner of page sections.

Screenshot 2024-05-29 at 4 57 39 PM

Screenshot 2024-05-29 at 4 57 31 PM

It doesn't seem we are updating the color of the scrollbar in dark theme like we were in PF5. Were we using color-theme: dark or something similar before that we are no longer using?

We could update the track color of the scrollbar using css scrollbar-color. This issue is especially obvious in Fedora machines.
We should also check the browser compatibility of the scrollbar-color style.

@mcoker
Copy link
Contributor

mcoker commented Jun 20, 2024

We updated the dark theme scrollbar color, but we need to move the scrollbar to an element with a border radius to have the scrollbar round on the edges with the parent container. I wonder if this can be addressed in patternfly/patternfly#6712? cc @evwilkin

@nicolethoen nicolethoen added this to the Penta final release milestone Jul 3, 2024
@nicolethoen nicolethoen transferred this issue from patternfly/patternfly Jul 3, 2024
@lboehling lboehling self-assigned this Sep 11, 2024
@lboehling
Copy link

Design refinements to improve scrollbar appearances in v6:

Here are several [hopefully small] adjustments to our page/sidebar components that should help with the appearance of scrollbars in v6: 



  • [Transparent track as mentioned above if possible]
  • Reduce the page border radius to border—radius—medium so the curve doesn't look as awkward cutting off the scrollbar. Placing within an element that can get a border radius might still help here @mcoker)
  • Reduce the border around the content area to global—spacer—xs, 4px(it was 8px before)
  • Adjust the nav scrollbar to have padding to its right so that it is centered between left nav and page body

With adjustments listed above:
image

Current state:
image

These adjustments should also help patternfly/patternfly#6834

Wdyt @nicolethoen @andrew-ronaldson @mcoker @thatblindgeye?

@mcoker
Copy link
Contributor

mcoker commented Sep 12, 2024

@lboehling nice! Put those together along with the scrollbar thumb/track update in patternfly/patternfly#7068.

I set the scrollbar thumb color to our border--color--default token, and set the track to transparent, and am only applying those styles to the main container and sidebar. Other things that scroll don't have that update, but could.

FWIW here's a screenshot without the scrollbar color updates, if you want to see what that looks like.

Screenshot 2024-09-11 at 8 39 43 PM

@mcoker
Copy link
Contributor

mcoker commented Sep 25, 2024

@lboehling with patternfly/patternfly#7101, can we close this issue?

@mcoker mcoker closed this as completed Sep 25, 2024
@mcoker mcoker reopened this Sep 25, 2024
@andrew-ronaldson
Copy link

Closed by patternfly/patternfly#7101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PatternFly 6 Design issues related to Penta work
Projects
Archived in project
Development

No branches or pull requests

4 participants