-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrollbar - transparent track #1315
Comments
We updated the dark theme scrollbar color, but we need to move the scrollbar to an element with a border radius to have the scrollbar round on the edges with the parent container. I wonder if this can be addressed in patternfly/patternfly#6712? cc @evwilkin |
Design refinements to improve scrollbar appearances in v6:
With adjustments listed above: These adjustments should also help patternfly/patternfly#6834 |
@lboehling nice! Put those together along with the scrollbar thumb/track update in patternfly/patternfly#7068. I set the scrollbar thumb color to our border--color--default token, and set the track to transparent, and am only applying those styles to the main container and sidebar. Other things that scroll don't have that update, but could. FWIW here's a screenshot without the scrollbar color updates, if you want to see what that looks like. |
@lboehling with patternfly/patternfly#7101, can we close this issue? |
Closed by patternfly/patternfly#7101 |
The corners of the scroll bar look odd beside the rounded corner of page sections.
It doesn't seem we are updating the color of the scrollbar in dark theme like we were in PF5. Were we using
color-theme: dark
or something similar before that we are no longer using?We could update the track color of the scrollbar using css
scrollbar-color
. This issue is especially obvious in Fedora machines.We should also check the browser compatibility of the scrollbar-color style.
The text was updated successfully, but these errors were encountered: