-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadows that are only on one side of a box #1310
Labels
PatternFly 6
Design issues related to Penta work
Comments
yeah, let's do this! was noticing this happen in a few sticky demos |
Design token updates to support this: I made these updates in this figma branch. If we're good with these changes, I can merge and create a follow up core/tokens issue to get these in! |
@lboehling lgtm! 🚀 |
merged into main figma file and opened patternfly/design-tokens#89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes we want to show a shadow only on one side of a box, on the bottom of a sticky header or top of a sticky footer, or on the right of a vertical nav/sidebar. Our shadows (or at least the ones I checked) show on all sides of a box, even if the main shadow is on one side. Usually this is OK - we can use a "top" shadow on a sticky footer, and whatever the container is for the sticky footer will just cut off the left/right/bottom shadow on the footer box. But depending on where the shadow is used, the excess shadows aren't always cut off.
We have a custom shadow in the sidebar component that applies a bottom shadow to the sidebar panel on narrow screens when it's above the sidebar content. The shadow was modified so that it only applies to the bottom, because we can't always predictably hide any excess shadows on the top/left/right from our standard shadows. Here's a screenshot of the sidebar shadow:
And here's a screenshot if we remove the custom shadow and use one of the standard "bottom" shadows.
A downside to this is that the shadow doesn't visually extend to the full edges of the side it's applied to.
WDYT - is this worth investigating and supporting these types of shadows and potentially updating some of our uses of directional shadows to use this type of shadow?
The text was updated successfully, but these errors were encountered: