-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical Navigation active item can be set when not navigated to. #706
Comments
Hi @Layla-P . Default active menu item is used for display selected status. I think it's a part of design intention. |
@Layla-P apologies for the delay. I'm looking into this... it makes sense to me that on click would navigate you however you could use hover to view the available options in the secondary. Does this address the concern? |
@jgiardino given you are looking into nav updates, will you take this feedback into consideration during those updates? |
This is definitely a JS update. JS is adding the |
Thanks for your input @jgiardino! |
Using the 2 level vertical navigation. If I click on a top level nav to open the second level but then decide not to navigate to any of the links in the secondary menu, the parent is made active even though I have not navigated to it.
I have fixed the issue by removing line 1408 (setActiveItem) in patternfly.js however, I have not tested that for any knock on effects.
The text was updated successfully, but these errors were encountered: