Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Navigation active item can be set when not navigated to. #706

Open
Layla-P opened this issue Aug 11, 2017 · 5 comments
Open

Vertical Navigation active item can be set when not navigated to. #706

Layla-P opened this issue Aug 11, 2017 · 5 comments
Labels

Comments

@Layla-P
Copy link

Layla-P commented Aug 11, 2017

Using the 2 level vertical navigation. If I click on a top level nav to open the second level but then decide not to navigate to any of the links in the secondary menu, the parent is made active even though I have not navigated to it.
I have fixed the issue by removing line 1408 (setActiveItem) in patternfly.js however, I have not tested that for any knock on effects.

@dabeng
Copy link
Contributor

dabeng commented Feb 6, 2018

Hi @Layla-P . Default active menu item is used for display selected status. I think it's a part of design intention.

@LHinson
Copy link
Member

LHinson commented Apr 30, 2018

@Layla-P apologies for the delay. I'm looking into this... it makes sense to me that on click would navigate you however you could use hover to view the available options in the secondary. Does this address the concern?

@LHinson
Copy link
Member

LHinson commented Jul 3, 2018

@jgiardino given you are looking into nav updates, will you take this feedback into consideration during those updates?

@jgiardino jgiardino removed their assignment Jul 9, 2018
@jgiardino
Copy link
Contributor

This is definitely a JS update. JS is adding the .active class on click. I think this could be reviewed as part of #723, which probably requires some design and JS investigation into what our options are.

@LHinson
Copy link
Member

LHinson commented Jul 9, 2018

Thanks for your input @jgiardino!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants