Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set id="title" in empty state component #575

Open
jeff-phillips-18 opened this issue Aug 17, 2017 · 3 comments
Open

Do not set id="title" in empty state component #575

jeff-phillips-18 opened this issue Aug 17, 2017 · 3 comments
Labels
bug good first issue Priority 2

Comments

@jeff-phillips-18
Copy link
Member

We shouldn't use id="title" in the empty state message. That's a really generic ID, and IDs need to be unique on the page.
@jeff-phillips-18 jeff-phillips-18 mentioned this issue Aug 17, 2017
Merged
5 tasks
@benjaminapetersen
Copy link
Member

@jeff-phillips-18 also curious, does it need to be an h1? Is it tied to style? Perhaps could use class="h1" but on a lesser heading.

@jeff-phillips-18 jeff-phillips-18 self-assigned this Aug 17, 2017
@jeff-phillips-18
Copy link
Member Author

I don't believe it needs to be an h1. I will look into that as well.

benjaminapetersen added a commit to benjaminapetersen/angular-patternfly that referenced this issue Aug 23, 2017
@benjaminapetersen
fix(empty state): Change h1 to h4 styled as h1, update to use unique …
cd163eb 
…id's generated by view

- fix issue patternfly#575
- h1 changed to h4 styled as h1
- update id's to be unique using {{$id}}
  - example: id="blank-state-pf-title-{{$id}}"
@jeff-phillips-18 jeff-phillips-18 removed their assignment Sep 12, 2017
@dtaylor113
Copy link
Member

Please see @akieling 's last commit in this Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Priority 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benjaminapetersen @jeff-phillips-18 @dtaylor113