Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port partiql-lang-kotlin signatures to partiql-plan #3

Open
RCHowell opened this issue Jul 9, 2024 · 0 comments
Open

Port partiql-lang-kotlin signatures to partiql-plan #3

RCHowell opened this issue Jul 9, 2024 · 0 comments

Comments

@RCHowell
Copy link
Member

RCHowell commented Jul 9, 2024

Relevant Issues

Description

  • What? — It dumps the existing (0.14) routines (ops/functions/aggregations) to a definitions file a’la substrait extensions.
  • Why? — We have to redefine all of the functions on PType now, so this is our indirection (which partiql-lang-rust may leverage)

This commit writes the current function signatures and variants to Ion files (like substrait extensions) so that PartiQL function signatures can be expressed independently of implementations. I am using these for my PR which moves functions out of SPI and into planner/eval respectively.

Open Questions

  • What might be some limitations of this representation?
  • Are the types sane for defining inputs/outputs?
  • How might packaging/namespacing fit into this? i.e. why even have sql99::… and partiql::… namespaces?
  • Is there value in these being public and consumed across PartiQL implementations, or is it just a nice-to-have for plk developers.
  • Where might these live long term if shared?
  • How are signatures stringified (specific/key) for representing in a plan?

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant