Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Function and aggregation improvements for typing and implementations. #1585

Open
RCHowell opened this issue Sep 16, 2024 · 0 comments
Open
Assignees

Comments

@RCHowell
Copy link
Member

RCHowell commented Sep 16, 2024

A couple of function things..

  • Functions (and aggregations) should be typed on their families rather than specific PTypes.
  • FnSignature (and AggSignature) should be removed in favor of the interface methods.
  • Functions (and aggregations) should have an implementation provider rather than a single invoke method.
  • Use type families rather than PTypes
  • Use a computeReturnType method like Calcite for function typing (massively simplifies PlanType logic...)
    /**
     * TODO REPLACE ME WITH `getInstance(args: Array<PType>)` which returns an invocable instance of this function.
     *
     * Invoke the function with the given arguments. Required.
     *
     * @param args the arguments to the function
     * @return the result of the function
     */
    public fun invoke(args: Array<Datum>): Datum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant