Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

switch to use http request instead of using komodo cli #12

Open
particle4dev opened this issue Dec 25, 2018 · 2 comments
Open

switch to use http request instead of using komodo cli #12

particle4dev opened this issue Dec 25, 2018 · 2 comments
Labels
rpc Issues related to rpc story Story provide verifiable business value to the team’s customer. technical debt Issues related to things that need improvement and that have been left behind due to high velocity o

Comments

@particle4dev
Copy link
Owner

Title: [Persona name] should (not) be able to [overarching action]

Business/User Value: Make source code testable

Acceptance Criteria
GIVEN [necessary context and preconditions for story]
WHEN [action]
THEN [reaction]

DEV NOTES
None

DESIGN Notes
None

---other items that you may add to a story---

NEEDS PM
None

NEEDS DESIGN
None

Related issues
None

/label ~"story"
@particle4dev particle4dev added story Story provide verifiable business value to the team’s customer. rpc Issues related to rpc technical debt Issues related to things that need improvement and that have been left behind due to high velocity o labels Dec 25, 2018
@pbca26
Copy link

pbca26 commented Dec 26, 2018

better to give an option what to use
in certain cases cli might be the only way to execute a command

@particle4dev
Copy link
Owner Author

particle4dev commented Dec 26, 2018 •
edited
Loading

@pbca26 I want to switch to use HTTP request because I want to make code testable
Tried to build a mock server and call it via komodo cli but it always fails
Then I took a look at bitcoin core lib (https://github.com/ruimarinho/bitcoin-core) they use HTTP request too (RPC call)
But yes, we can keep both

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
rpc Issues related to rpc story Story provide verifiable business value to the team’s customer. technical debt Issues related to things that need improvement and that have been left behind due to high velocity o
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@particle4dev @pbca26