Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test suite against enableSchemaHooks #8353

Open
3 tasks done
dplewis opened this issue Dec 19, 2022 · 8 comments
Open
3 tasks done

Run test suite against enableSchemaHooks #8353

dplewis opened this issue Dec 19, 2022 · 8 comments
Labels
type:ci CI related issue

Comments

@dplewis
Copy link
Member

dplewis commented Dec 19, 2022

New Feature / Enhancement Checklist

Feature / Enhancement Description

There is a post on discourse about enableSchemaHooks not being supported
https://community.parseplatform.org/t/parseerror-130-option-enableschemahooks-is-not-supported-since-5-3-0/3041

Running the test suite will allow us to catch errors as the code base improves or Mongo updates.

I did it on my fork and only found 1 issue
dplewis#2

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

@mtrezza
Copy link
Member

mtrezza commented Dec 20, 2022

You mean running all tests with and without schema hooks enabled?

@mtrezza mtrezza added the type:ci CI related issue label Dec 20, 2022
@tomgrowflow
Copy link

tomgrowflow commented Sep 28, 2023

the issue is that enableSchemaHooks is being passed to GridFSBucketAdapter

and enableSchemaHooks is not a valid mongo db connection option.

it'd be better to split this out into it's own option instead of mixing it with mongo db connection options.

const filesControllerAdapter = loadAdapter(filesAdapter, () => {
// this line of code fixes it
delete databaseOptions.enableSchemaHooks;
return new GridFSBucketAdapter(databaseURI, databaseOptions, fileKey);
});

image

@tomgrowflow
Copy link

tomgrowflow commented Sep 28, 2023

I'm running into this issue now and it's preventing us from upgrading from v 4.x to 5.5.3, any way we can get this pr merged?

note: we are using parse docker image

image: parseplatform/parse-server:5.5.3

and setting environment variables..

  • name: PARSE_SERVER_DATABASE_OPTIONS
    value: '{"enableSchemaHooks":true,"maxPoolSize":10,"compressors":"zlib","useNewUrlParser":true,"useUnifiedTopology":true}'

@tomgrowflow
Copy link

this pr looks to fix it but it's not back ported to version 5

https://github.com/parse-community/parse-server/pull/8467/files

@mtrezza
Copy link
Member

mtrezza commented Oct 1, 2023

@tomwilsond1 The PR you mentioned is not backported to 5.x because only security vulnerabilities are backported to LTS versions. The PR looks pretty simple though, if you would like to open a PR against the 5.x branch with the same changes we'll gladly review it. This would need to be done soon though, because Parse Server 5 will be out of LTS in 3 months, and from then on it won't receive any maintenance anymore and will be archived. Due to that it may make more sense for you to upgrade to Parse Server 6 directly, which will already be in LTS from Jan 2024.

@tomgrowflow
Copy link

we are pretty deep into migrating from 4->5 and this is the last blocking issue for us, would it be possible to merge this fix into 5.x and complete a hotfix?

https://github.com/parse-community/parse-server/pull/8773/files

@mtrezza
Copy link
Member

mtrezza commented Oct 10, 2023

Sure, we'll be happy to review and merge your PR within the LTS time frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci CI related issue
Projects
None yet
Development

No branches or pull requests

3 participants