-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test suite against enableSchemaHooks #8353
Comments
Thanks for opening this issue!
|
You mean running all tests with and without schema hooks enabled? |
the issue is that enableSchemaHooks is being passed to GridFSBucketAdapter and enableSchemaHooks is not a valid mongo db connection option. it'd be better to split this out into it's own option instead of mixing it with mongo db connection options. const filesControllerAdapter = loadAdapter(filesAdapter, () => { |
I'm running into this issue now and it's preventing us from upgrading from v 4.x to 5.5.3, any way we can get this pr merged? note: we are using parse docker image image: parseplatform/parse-server:5.5.3 and setting environment variables..
|
this pr looks to fix it but it's not back ported to version 5 https://github.com/parse-community/parse-server/pull/8467/files |
@tomwilsond1 The PR you mentioned is not backported to 5.x because only security vulnerabilities are backported to LTS versions. The PR looks pretty simple though, if you would like to open a PR against the 5.x branch with the same changes we'll gladly review it. This would need to be done soon though, because Parse Server 5 will be out of LTS in 3 months, and from then on it won't receive any maintenance anymore and will be archived. Due to that it may make more sense for you to upgrade to Parse Server 6 directly, which will already be in LTS from Jan 2024. |
we are pretty deep into migrating from 4->5 and this is the last blocking issue for us, would it be possible to merge this fix into 5.x and complete a hotfix? https://github.com/parse-community/parse-server/pull/8773/files |
Sure, we'll be happy to review and merge your PR within the LTS time frame. |
New Feature / Enhancement Checklist
Feature / Enhancement Description
There is a post on discourse about enableSchemaHooks not being supported
https://community.parseplatform.org/t/parseerror-130-option-enableschemahooks-is-not-supported-since-5-3-0/3041
Running the test suite will allow us to catch errors as the code base improves or Mongo updates.
I did it on my fork and only found 1 issue
dplewis#2
The text was updated successfully, but these errors were encountered: