From 24188a39a71bf4e40eb9115bf47008450b10ad87 Mon Sep 17 00:00:00 2001 From: Manuel <5673677+mtrezza@users.noreply.github.com> Date: Sat, 4 Sep 2021 03:03:46 +0200 Subject: [PATCH] refactor: remove restricted session field (#7543) * add issue bot for prs * Update CHANGELOG.md * Update issue-bot.yml * remove session restriction artifacts * Update CHANGELOG.md * Update CHANGELOG.md --- CHANGELOG.md | 1 + spec/Schema.spec.js | 1 - src/Controllers/SchemaController.js | 1 - src/RestWrite.js | 1 - 4 files changed, 1 insertion(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 162cf851d8..d783c4b460 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -103,6 +103,7 @@ ___ - Remove support for MongoDB 3.6 which has reached its End-of-Life date and PostgreSQL 10 (Manuel Trezza) [#7315](https://github.com/parse-community/parse-server/pull/7315) - Remove support for Node 10 which has reached its End-of-Life date (Manuel Trezza) [#7314](https://github.com/parse-community/parse-server/pull/7314) - Remove S3 Files Adapter from Parse Server, instead install separately as `@parse/s3-files-adapter` (Manuel Trezza) [#7324](https://github.com/parse-community/parse-server/pull/7324) +- Remove Session field `restricted`; the field was a code artifact from a feature that never existed in Open Source Parse Server; if you have been using this field for custom purposes, consider that for new Parse Server installations the field does not exist anymore in the schema, and for existing installations the field default value `false` will not be set anymore when creating a new session (Manuel Trezza) [#7543](https://github.com/parse-community/parse-server/pull/7543) ### Notable Changes - Added Parse Server Security Check to report weak security settings (Manuel Trezza, dblythy) [#7247](https://github.com/parse-community/parse-server/issues/7247) diff --git a/spec/Schema.spec.js b/spec/Schema.spec.js index 0975260a4b..7f5b5650fc 100644 --- a/spec/Schema.spec.js +++ b/spec/Schema.spec.js @@ -892,7 +892,6 @@ describe('SchemaController', () => { objectId: { type: 'String' }, updatedAt: { type: 'Date' }, createdAt: { type: 'Date' }, - restricted: { type: 'Boolean' }, user: { type: 'Pointer', targetClass: '_User' }, installationId: { type: 'String' }, sessionToken: { type: 'String' }, diff --git a/src/Controllers/SchemaController.js b/src/Controllers/SchemaController.js index 90f32b0b16..c9c51e71ad 100644 --- a/src/Controllers/SchemaController.js +++ b/src/Controllers/SchemaController.js @@ -70,7 +70,6 @@ const defaultColumns: { [string]: SchemaFields } = Object.freeze({ }, // The additional default columns for the _Session collection (in addition to DefaultCols) _Session: { - restricted: { type: 'Boolean' }, user: { type: 'Pointer', targetClass: '_User' }, installationId: { type: 'String' }, sessionToken: { type: 'String' }, diff --git a/src/RestWrite.js b/src/RestWrite.js index ec13e5aa46..360c7e0dc0 100644 --- a/src/RestWrite.js +++ b/src/RestWrite.js @@ -891,7 +891,6 @@ RestWrite.createSession = function ( objectId: userId, }, createdWith, - restricted: false, expiresAt: Parse._encode(expiresAt), };