Objects uploaded with generateKey return incorrect locations

[AdrianCurtin]

From parse-server\lib\Controllers\FilesController.js - line 32

const location = await this.adapter.getFileLocation(config, filename);
    await this.adapter.createFile(filename, data, contentType, options);
    return {
      url: location,
      name: filename
    };

Location is a const fed in from getFileLocation, but getFileLocation will always return the location before key generation occurs.

object location created by this.adpter.createFile as an output argument is discarded.
Additionally, getFileLocation will return the presigned item based on the old filename rather than the new file name.

Ex:

generateKey: (filename) => {
  return ${Date.now()}_${filename}; // unique prefix for every filename
}

Uploading "file.jpeg" will result in XXX.s3.amazonaws.com/file.jpeg as a key while uploading to XXX.s3.amazonaws.com/XXXX_file.jpeg

getFileLocation will return the full (optionally presignedUrl) or "https://${this._bucket}.s3.amazonaws.com/${this._bucketPrefix}${fileName}" where fileName is file.jpeg

However createFile will instead return a location of
https://${this._bucket}.s3.${this._region}.amazonaws.com/this._bucketPrefix + this._generateKey(filename)

Until this issue is fixed, generateKey should be considered to be non-functional. Either the filename should be rewritten with the generated Key prior to getFileLocation (and the createFile call should not generate a new key) or the FilesController.js should be wrapped to account for this.

[parse-github-assistant]

Thanks for opening this issue!

[mtrezza]

What version of the adapter has this issue? Did you try different versions to see where this issues started to occur?

[AdrianCurtin]

I'm using v4.0 but best I can tell from the code inspection since it appears to be related to a need to work around the parse-server integration, this issue would pre-exist the new release.

…

On Thu, Jan 9, 2025 at 8:10 AM Manuel ***@***.***> wrote: What version of the adapter has this issue? Did you try different versions to see where this issues started to occur? — Reply to this email directly, view it on GitHub <#237 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALPIOR6CMC2VTG6TT7YYUZD2JZYNZAVCNFSM6AAAAABU3HEZISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBQGEYTSMJTHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Adrian Curtin, PhD Drexel University School of Biomedical Engineering ***@***.*** (484)-995-8774