Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse.ParseUser.LogOutAsync test fails #400

Closed
4 tasks done
mtrezza opened this issue Dec 20, 2024 · 9 comments · Fixed by #403
Closed
4 tasks done

Parse.ParseUser.LogOutAsync test fails #400

mtrezza opened this issue Dec 20, 2024 · 9 comments · Fixed by #403
Labels
state:released Released as stable version type:bug

Comments

@mtrezza
Copy link
Member

mtrezza commented Dec 20, 2024

New Issue Checklist

Issue Description

Parse.ParseUser.LogOutAsync test fails.

Steps to reproduce

See https://github.com/parse-community/Parse-SDK-dotNET/actions/runs/12424201056/job/34688986371#step:8:867.

Copy link

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza
Copy link
Member Author

mtrezza commented Dec 20, 2024

@YBTopaz8 could you take a look this if you have some time? The CI is currently failing, which may be the issue one can see in your screenshot in #393 (comment). At the time I assumed that you fixed the failing test, because the CI passed in that PR, but it turned out that there was a bug in the CI that ignored failing tests. I've fixed the CI bug in #398, so the CI fails now properly. But of course we need to get the CI passing. From the CI point of view we don't know whether that is a test issue or a feature issue.

@YBTopaz8
Copy link
Member

Appreciate the insight.
I'm fairly sure it's a test issues as logout works well trying to see from what angle I can fix the test.
Would you like for me to do several PRs as I fix issues moving forward, or would you prefer one PR to be done (before the LQ PR)

By the way for LQ, before release, we will need to do the documentation.
We would need to do the docs for all of .NET since it's still talking about XAMARIN.
If all the same to you, I can update the docs over the weekend - Just need to show me around.

@mtrezza
Copy link
Member Author

mtrezza commented Dec 20, 2024

Yes, please one PR per issue; also see here.

Sure, the docs are in the docs repo. If you just go through the _includes directory you'll easily figure out the modular structure of the docs and where to edit.

@YBTopaz8
Copy link
Member

Good News!
All tests pass even the LogOut and Link.
Bad News : Our coverage probably dropped (since I have now 189 tests instead of 200 as initially)

Another good news: I decided to learn UT so, I'll be adding more UT to improve coverage to be at least back to before v4.0 OR better covered.

Cheers.

@mtrezza
Copy link
Member Author

mtrezza commented Dec 20, 2024

Could you please link your PR to this issue so we can review?

@YBTopaz8
Copy link
Member

#402

@mtrezza
Copy link
Member Author

mtrezza commented Dec 21, 2024

Could you please open a separate PR just for this issue, without including any other changes? Please see here why. I assume it should be a relatively small PR.

YBTopaz8 added a commit that referenced this issue Dec 21, 2024
Fixed an issue Parse LogoutAsync's test would not pass.
Closes #400
@parseplatformorg
Copy link

🎉 This change has been released in version 4.0.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version type:bug
Projects
None yet
3 participants