Add litep2p network protocol benches #6455
Merged
+164
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiEres
added
R0-silent
|
As a side note to the PR description: how to interpret the plot axes? Naive understanding brings the question up why the time is the same for 10^3 bytes and for 10^6 bytes? |
lexnv
approved these changes
Nov 13, 2024
Either the worker initialization or the size difference is not significant. |
|
/cmd prdoc --audience node_dev --bump silent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to run networking protocol benchmarks with litep2p backend.
Now we can compare the work of both libp2p and litep2p backends for notifications and request-response protocols.
Next step: extract worker initialization from the benchmark loop.
Example run on local machine
Integration
Does not affect downstream projects.
Review Notes
polkadot-sdk/substrate/client/network/src/litep2p/service.rs
Lines 510 to 520 in d4d9502
This method should be implemented to run request benchmarks.