Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pallet weights every week #6196

Open
ggwpez opened this issue Oct 23, 2024 · 1 comment
Open

Update pallet weights every week #6196

ggwpez opened this issue Oct 23, 2024 · 1 comment
Assignees

Comments

@ggwpez
Copy link
Member

ggwpez commented Oct 23, 2024

With changes to FRAME, the Rust compiler version, pallets and the benchmarker itself, we should try to update the pallet weights on a weekly basis to see regressions early and not just before a release.

Task: Update the weights of all pallets from all runtimes every week. It should re-use the already open MR and force-push there, to avoid spamming up new MRs if reviews are slow.

@mordamax mordamax self-assigned this Oct 23, 2024
@bkchr
Copy link
Member

bkchr commented Oct 23, 2024

Task: Update the weights of all pallets from all runtimes every week. It should re-use the already open MR and force-push there, to avoid spamming up new MRs if reviews are slow.

No no. These prs should be merged automatically if the weight changes are not a regression. Generally I would also expect if these kind of prs exist they should also get merged. No need to bring this stuff up and then it lays around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants