-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would implementing a basic support for the JsonRPC 1.0 be useful on the client? #1312
Comments
Hey @YaCodesDevelopment. @Velnbur commented on this recently as well
After double checking the JSON-RPC v1 spec the difference is as follows:
I'm not sure whether it's possible to support that via feature flags because it may have some edge causes especially So if any of you want to tackle to add the feature flags "v1 and v2" to jsonrpsee_types go ahead with the risk that we may not accept it if there is no clean and maintainable solution to it (my gut feeling is that it may be easier to just create another library for it) Another thoughts from you? Bitcoin is not going to migrate to JSON-RPC v2 soon? |
I had the idea to create another library for it too, especially since I don't need the server part. It shouldn't be too difficult to implement. Just wanted to know your thoughts about that, as I couldn't find any mentions that
It has been under development for over a year with some activity, but it seems it won't be merged in nearest future (checkout bitcoin/bitcoin#27101) |
Thanks for your reply. I guess in such case I'm really better of creating my own library. Sorry for bothering you) |
If so, I could implement it, so that it wouldn't fail when doing requests to JsonRPC 1.0. (I'll test it on Bitcoin RPC node).
It's mostly useful for Bitcoin RPC I guess, as it's very popular use-case and it only supports 1.0
The text was updated successfully, but these errors were encountered: