-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use static version instead of tag: latest
for the node helm chart
#41
Comments
It doesn't make sense to me to do it and will be a big maintainance burger. Moreover, the node chart doesn't support only polkadot but also any other substrate chain, so it would not make sense to release new version of the chart containing just a change of the default tag for |
well, this is the usual thing that all the great companies do for their helm charts. Supporting polkadot and other substrate chains don't interfere with having the version pinned in the helm chart instead of using the latest tag imo. I believe that's also the idea behind having APP VERSION in all the |
Just to chime in, if you look at organisations that maintain a large amount of helm charts I.E. Bitnami they always pin to an With a helm chart you ideally are looking for stability as a default behaviour and using tag |
For me, it would be okay to set the version explicitly if we can have an automated bot submitting PRs when new version are available. |
Another alternative is submitting the charts to ArtifactHub and annotating the charts as per https://artifacthub.io/docs/topics/annotations/helm/ Although it's not perfect for a github native approach. |
My conclusion about this topic is that it's not useful to set something different than |
Currently, when a new polkadot release is available, people should change their values files to point to the new version.
I think the best is to release a new version for the
node
helm chart per each release and use the chartappVersion
as default for the image tag, then people who are using our chart for their deployment can easily update their nodes by bumping the chart version instead of editing thevalues.yaml
file manually or by a pipeline.The text was updated successfully, but these errors were encountered: