From dd8ca52ca56abc3ebc9abc28ff3e29b8d7b3f202 Mon Sep 17 00:00:00 2001 From: Kemal Akkoyun Date: Wed, 8 Nov 2023 20:27:43 +0100 Subject: [PATCH] Fix shellcheck warnings Signed-off-by: Kemal Akkoyun --- mojo/build_mojo_image.sh | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/mojo/build_mojo_image.sh b/mojo/build_mojo_image.sh index d0d6a12..c37c4fe 100755 --- a/mojo/build_mojo_image.sh +++ b/mojo/build_mojo_image.sh @@ -29,21 +29,21 @@ container_engine=${container_engine:=docker} extra_cap=${extra_cap:=} while [ $# -gt 0 ]; do case "$1" in - --auth-key) - user_key="$2" - shift - ;; - --use-podman) - container_engine=podman - extra_cap="--cap-add SYS_PTRACE" - ;; - --mojo-version) - mojo_ver="$2" - shift - ;; - --*) - echo "Unrecognized option $1" - ;; + --auth-key) + user_key="$2" + shift + ;; + --use-podman) + container_engine=podman + extra_cap="--cap-add SYS_PTRACE" + ;; + --mojo-version) + mojo_ver="$2" + shift + ;; + --*) + echo "Unrecognized option $1" + ;; esac shift $(($# > 0 ? 1 : 0)) done @@ -58,11 +58,11 @@ check_options() { build_image() { check_options echo "# Building image with ${container_engine}..." - ${container_engine} build --no-cache ${extra_cap} \ - --build-arg AUTH_KEY=${user_key} \ - --pull -t modular/mojo-v${mojo_ver} \ + ${container_engine} build --no-cache "${extra_cap}" \ + --build-arg AUTH_KEY="${user_key}" \ + --pull -t modular/mojo-v"${mojo_ver}" \ --file Dockerfile.mojo . - ${container_engine} tag modular/mojo-v${mojo_ver} modular/mojo:latest + ${container_engine} tag modular/mojo-v"${mojo_ver}" modular/mojo:latest } # Wrap the build in a function