Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Opstack engine api jsonrpsee trait #14211

Open
Tracked by #13145
mattsse opened this issue Feb 4, 2025 · 3 comments
Open
Tracked by #13145

Add Opstack engine api jsonrpsee trait #14211

mattsse opened this issue Feb 4, 2025 · 3 comments
Assignees
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 4, 2025

Describe the feature

same as

pub trait EngineApi<Engine: EngineTypes> {

but with Opstack types for newPayload v4, we can now then also exclude the v1 endpoints

this should be added to the optimism rpc crate probably.

I also think now that we're splitting those, we no longer need the T: EngineTypes generic on that trait.

Additional context

#13145

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 4, 2025
@mattsse mattsse added A-op-reth Related to Optimism and op-reth and removed S-needs-triage This issue needs to be labelled labels Feb 4, 2025
@emhane
Copy link
Member

emhane commented Feb 4, 2025

@emhane
Copy link
Member

emhane commented Feb 4, 2025

will open issue to address the redundancy with above trait at later time point in order not to block this issue which is critical for isthmus l2 withdrawals root feature

@mattsse
Copy link
Collaborator Author

mattsse commented Feb 4, 2025

most of the functions yes, but we need an jsonrpsee trait for this

will open issue to address the redundancy

there is none, this op-alloy trait is for alloy provider, client side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants