Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSP-643] Defining WP_HOME and WP_SITEURL in wp-config.php causes PHP notice #353

Open
marfillaster opened this issue Feb 3, 2023 · 0 comments · May be fixed by #354
Open

[CMSP-643] Defining WP_HOME and WP_SITEURL in wp-config.php causes PHP notice #353

marfillaster opened this issue Feb 3, 2023 · 0 comments · May be fixed by #354

Comments

@marfillaster
Copy link

There are use-cases when WP_HOME and WP_SITEURL need to be derived from an alternative header other than HTTP_HOST. These constants are already being defined in wp-config-pantheon.php. Defining these constants before or after include 'wp-config-pantheon.php'; in wp-config.php will cause PHP notice. Since wp-config-pantheon.php is upstream maintained, we do not recommend modifying the file due to potential merge conflict in the future. Including a modified copy of wp-config-pantheon.php is what we suggest but any future update will require user to manually reconcile the files.

Proposed solution: Make the define statement in wp-config-pantheon.php conditional.

marfillaster added a commit to marfillaster/WordPress that referenced this issue Feb 3, 2023
marfillaster added a commit to marfillaster/WordPress that referenced this issue Feb 3, 2023
@pwtyler pwtyler changed the title Defining WP_HOME and WP_SITEURL in wp-config.php causes PHP notice [CMSP-643] Defining WP_HOME and WP_SITEURL in wp-config.php causes PHP notice Aug 30, 2023
pwtyler pushed a commit to marfillaster/WordPress that referenced this issue Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant