Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Password-protected rooms #13

Open
janlelis opened this issue May 8, 2020 · 4 comments
Open

Feature request: Password-protected rooms #13

janlelis opened this issue May 8, 2020 · 4 comments

Comments

@janlelis
Copy link
Member

janlelis commented May 8, 2020

  • First user who joins a room includes a password in their join message
  • Other users joining the channel need that password in their join message, too

What do you think?

@farao
Copy link
Member

farao commented May 23, 2020

Proposition for a protocol change: Make the join_room take an optional "password" field. What would then need to happen:

  • if the room does not exist yet and password field is set: make the room password protected
  • if somebody wants to join a password protected room: if password is set and is the same: all as usual, if password is wrong, send back a {event: "error", description: "password_mismatch"} event

@janlelis
Copy link
Member Author

Sounds good to me 👍

@erikzenker
Copy link
Member

We should make a little threat analysis. Maybe in a meeting?

@farao
Copy link
Member

farao commented May 31, 2020

I would be up to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants