Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To support node and non node envs, do we need to release two packages, one with an fs dep #30

Closed
YOU54F opened this issue Mar 3, 2022 · 1 comment

Comments

@YOU54F
Copy link
Member

YOU54F commented Mar 3, 2022

so based on the following

https://github.com/YOU54F/msw-pact/tree/mswImprovements#custom-file-writers

we can provide a file writer for where we use a worker.

currently, we package use fs as a dep for the server node based invocation.

see https://github.com/YOU54F/examples/pull/1 for error running msw with-karma example with error

do we need to release two packages, one for a worker, one for a server, and the worker drops the fs dep and always expects a custom writer?

@YOU54F
Copy link
Member Author

YOU54F commented Mar 7, 2022

version published as [email protected] thanks @IJuanI

@YOU54F YOU54F closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant