Too many copr builds triggered when tests jobs are defined #2669
Labels
area/copr
Related to the integration with copr.fedorainfracloud.org/
complexity/single-task
Regular task, should be done within days.
gain/high
This brings a lot of value to (not strictly a lot of) users.
impact/high
This issue impacts multiple/lot of users.
kind/bug
Something isn't working.
Working on re-triggering of failed tests, I realized we are triggering non needed copr builds.
The above snippet is taken from this PR; one copr build for
rawhide
and one forf41
withlatest
identifier should be enough, instead we are triggering even therawhide
build in the copr repo withlatest
identifier and thef41
build in the copr repo with no identifier.This is caused by the definition of tests jobs (not listed in the snippet) for which we are looking in all defined targets:
packit-service/packit_service/worker/helpers/build/build_helper.py
Lines 94 to 96 in d6b6a6e
There are no issues for any user but we are wasting resources.
There is also another issue related with the wrong
build_targets
count.packit-service/packit_service/worker/jobs.py
Lines 359 to 360 in d6b6a6e
We are submitting the wrong number of build_targets (for too many times) to the pushgateway.
When there are multiple copr jobs defined and there is also at least one test job defined, we are submitting for every copr job and every test job the sum of all defined targets (since the CoprBuildJobHelper is initialized even for the tests jobs).
I think this is the cause of our wrong metrics #2430 (we have many more queued tasks than started or finished).
The text was updated successfully, but these errors were encountered: