Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider identifiers for OpenScanHub reporting #2653

Closed
2 tasks
lbarcziova opened this issue Nov 22, 2024 · 0 comments · Fixed by #2674
Closed
2 tasks

Consider identifiers for OpenScanHub reporting #2653

lbarcziova opened this issue Nov 22, 2024 · 0 comments · Fixed by #2674
Assignees
@lbarcziova
Labels
area/openscanhub complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@lbarcziova
Copy link
Member

lbarcziova commented Nov 22, 2024 •
edited
Loading

For projects with multiple Copr build jobs configured (e.g. monorepositories), we submit multiple scans, but when reporting, use just one check name, which results in overwriting the statuses and informing the user just about one scan.

TODO:

  • include the identifier (of the Copr build job) in the check name for the OpenScanHub job
  • implement pre-check for the OSH results handler to check for matching identifiers (we might need to store the identifier in the DB)
@lbarcziova lbarcziova added kind/bug Something isn't working. complexity/single-task Regular task, should be done within days. area/openscanhub labels Nov 22, 2024
@siteshwar siteshwar mentioned this issue Nov 22, 2024
Open
@lachmanfrantisek lachmanfrantisek added impact/low This issue impacts only a few users. gain/high This brings a lot of value to (not strictly a lot of) users. labels Nov 25, 2024
@lachmanfrantisek lachmanfrantisek moved this from new to priority-backlog in Packit Kanban Board Nov 25, 2024
@lbarcziova lbarcziova moved this from priority-backlog to in-progress in Packit Kanban Board Dec 10, 2024
@lbarcziova lbarcziova self-assigned this Dec 10, 2024
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Dec 10, 2024
@lbarcziova
Consider identifiers for OpenScanHub
c513f46 
Fixes packit#2653
@lbarcziova lbarcziova mentioned this issue Dec 10, 2024
Merged
@lbarcziova lbarcziova moved this from in-progress to in-review in Packit Kanban Board Dec 10, 2024
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Dec 10, 2024
@lbarcziova
Consider identifiers for OpenScanHub
3b203af 
Fixes packit#2653
softwarefactory-project-zuul bot added a commit that referenced this issue Dec 19, 2024
@softwarefactory-project-zuul
Consider identifiers for OpenScanHub (#2674)
1655de9 
Consider identifiers for OpenScanHub

Fixes #2653
RELEASE NOTES BEGIN
We have fixed the reporting of OpenScanHub jobs when identifiers for Copr build jobs are configured.
RELEASE NOTES END

Reviewed-by: Maja Massarini
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/openscanhub complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider identifiers for OpenScanHub lbarcziova/packit-service
2 participants
@lachmanfrantisek @lbarcziova