Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"PR does not contain a specfile change" but it does #2287

Closed
2 tasks
majamassarini opened this issue Dec 19, 2023 · 1 comment · Fixed by packit/ogr#827 or #2289
Closed
2 tasks

"PR does not contain a specfile change" but it does #2287

majamassarini opened this issue Dec 19, 2023 · 1 comment · Fixed by packit/ogr#827 or #2289
Assignees
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/bug Something isn't working.

Comments

@majamassarini
Copy link
Member

What happened? What is the problem?

After merging this PR https://src.fedoraproject.org/rpms/ddnet/pull-request/4 packit does not react creating a koji build and bodhi update.

Looking in sentry I can see:

12/19/23
10:56:17.153 AM	
2023-12-19T10:56:17.153909576+00:00 stderr F [2023-12-19 10:56:17,153: ERROR/MainProcess] {'error': 'No statistics could be computed for this PR', 'error_code': 'ENOPRSTATS'}
12/19/23
10:56:17.157 AM	
2023-12-19T10:56:17.157516615+00:00 stderr F [2023-12-19 10:56:17,157: INFO/MainProcess] PR 4 does not contain a specfile change.

But the PR has a change in the specfile.

What did you expect to happen?

No response

Example URL(s)

No response

Steps to reproduce

1.
2.
3.

What is the impacted category (job)?

Fedora release automation

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@majamassarini majamassarini added the kind/bug Something isn't working. label Dec 19, 2023
@majamassarini majamassarini changed the title "PR does not contain a specfile change" but id does "PR does not contain a specfile change" but it does Dec 19, 2023
@majamassarini majamassarini self-assigned this Dec 20, 2023
@github-project-automation github-project-automation bot moved this from new to done in Packit Kanban Board Dec 20, 2023
softwarefactory-project-zuul bot added a commit to packit/ogr that referenced this issue Dec 20, 2023
Fix race condition causing ENOPRSTATS

When we get the ENOPRSTATS exception from Pagure there is a race condition.
We can try to run the call again and see if it solves the problem.
Fixes packit/packit-service#2287
Merge before packit/packit-service#2289

Reviewed-by: Nikola Forró
Reviewed-by: Maja Massarini
@majamassarini majamassarini added area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. impact/high This issue impacts multiple/lot of users. gain/high This brings a lot of value to (not strictly a lot of) users. labels Dec 20, 2023
@majamassarini majamassarini moved this from done to in-review in Packit Kanban Board Dec 20, 2023
softwarefactory-project-zuul bot added a commit that referenced this issue Dec 20, 2023
Handle race condition causing ENOPRSTATS

Fixes #2287
Merge after packit/ogr#827
RELEASE NOTES BEGIN
We have handled an exception causing Koji builds and Bodhi updates not be run after merging a Packit downstream pull request.
RELEASE NOTES END

Reviewed-by: Nikola Forró
Reviewed-by: Maja Massarini
@lbarcziova
Copy link
Member

thanks for investigating and fixing this!

@majamassarini majamassarini moved this from in-review to done in Packit Kanban Board Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/bug Something isn't working.
Projects
Archived in project
2 participants