Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagure API sometimes returns 404 #221

Open
TomasTomecek opened this issue Jul 14, 2021 · 3 comments
Open

Pagure API sometimes returns 404 #221

TomasTomecek opened this issue Jul 14, 2021 · 3 comments

Comments

@TomasTomecek
Copy link
Member

Traceback (most recent call last):
  File "/usr/local/bin/dist2src", line 11, in <module>
    load_entry_point('dist-git-to-source-git==0.1.dev1+g99614a9.d20210629', 'console_scripts', 'dist2src')()
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1668, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/dist2src/cli.py", line 248, in check_updates
    Updater().check_updates(project, branch)
  File "/usr/local/lib/python3.6/site-packages/dist2src/worker/updater.py", line 69, in check_updates
    self._check_and_update_project(project_to_be_processed, branch=branch)
  File "/usr/local/lib/python3.6/site-packages/dist2src/worker/updater.py", line 99, in _check_and_update_project
    for branch, commit in self._get_out_of_date_branches(project, branch):
  File "/usr/local/lib/python3.6/site-packages/dist2src/worker/updater.py", line 127, in _get_out_of_date_branches
    r = self.cfg.dist_git_svc.call_api(url, params={"with_commits": True})
  File "/usr/lib/python3.6/site-packages/ogr/services/pagure/service.py", line 144, in call_api
    pagure_error=error_msg,
ogr.exceptions.PagureAPIException: Page 'https://git.centos.org/api/0/rpms/bibutils/git/branches' not found when calling Pagure API.

even though it's there and should return 200

@mfocko
Copy link
Member

mfocko commented Jul 14, 2021

imo it's something like 502, not sure why they chose 404 and it definitely doesn't make sense to retry 404 🤷‍♂️

@TomasTomecek
Copy link
Member Author

TomasTomecek commented Jul 14, 2021

404 was just my guess based on the "not found"

also gitlab returns 5xx - we have a bunch of such errors in logs right now

¯\_(ツ)_/¯

@mfocko
Copy link
Member

mfocko commented Jul 14, 2021

i know it's 404, have seen some of the events in Sentry and thought it's the problem with retry mechanism and then noticed it's 404

I meant that Pagure API returns it even when it's supposed to return something like 502, since I couldn't see any pattern with the repositories and it happens only here and there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants