Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch'es original author & commit message not preserved #110

Open
jpopelka opened this issue Oct 27, 2020 · 1 comment
Open

Patch'es original author & commit message not preserved #110

jpopelka opened this issue Oct 27, 2020 · 1 comment
Labels
kind/feature New feature or a request for enhancement.

Comments

@jpopelka
Copy link
Member

For example:

I'd expect to see Packit as a committer but not as the original author. And also the original commit messages disappeared.

@TomasTomecek
Copy link
Member

This one has an easy answer: the patches are applied via specfile's %prep, so when they are applied with /usr/bin/patch, we just let patch do the job and get on with our lives. If packagers wanted commits to be owned by authors, they would need to let git apply it (via %autopatch -S git[_am])

At this point I wanted to wontfix this but since you are not a packager, I'm thinking from a different perspective now. Yours.

It would indeed be nice if authorship was correct if possible - since we are hooked into the patch process and the data are there, we could somehow get them and do git commit --amend --author ... after the patch is applied by /usr/bin/patch

@TomasTomecek TomasTomecek added the kind/feature New feature or a request for enhancement. label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or a request for enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants