Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore fields for ContentEq and ContentHash #8432

Closed
overlookmotel opened this issue Nov 25, 2024 · 1 comment
Closed

Ignore fields for ContentEq and ContentHash #8432

overlookmotel opened this issue Nov 25, 2024 · 1 comment

Comments

@overlookmotel
Copy link
Contributor

Fields which are concrete syntax tree-like details of literal AST types should be ignored by ContentEq and ContentHash:

  • raw fields.
  • base: NumberBase in NumericLiteral.
  • base: BigintBase in BigIntLiteral.

These fields are not "content" in the same way as span: Span fields are not.

Implement this with a #[content(ignore)] attr which ast_tools codegen understands.
@overlookmotel overlookmotel transferred this issue from oxc-project/backlog Jan 11, 2025
@overlookmotel
Copy link
Contributor Author

Implemented in #8426.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@overlookmotel