Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Encryption 1.5.2 #338

Closed
33 of 36 tasks
IljaN opened this issue May 23, 2022 · 10 comments · Fixed by #344
Closed
33 of 36 tasks

Release Encryption 1.5.2 #338

IljaN opened this issue May 23, 2022 · 10 comments · Fixed by #344
Assignees
Milestone

Comments

@IljaN
Copy link
Contributor

IljaN commented May 23, 2022

Reason

Product approval

  • Verify transifex commits are in master: If a folder https://github.com/owncloud//tree/master/l10n exists, then https://drone.owncloud.com/owncloud/ should receive nightly '[tx] updated from transifex` ...
  • Ping pmaier to check info.xml description and screenshot
  • Get approval on translations from pmaier - send the date of the last tx commit from drone to Patrick

QA

  • Create QA Milestone and set the description to $version
  • Move tickets from milestone development to qa (testplan and tickets mentioned in release ticket)
  • Create release branch with the format "release-$version"
  • Create "$version Testplan" -> [QA] 1.5.2 Testplan #339
  • copy new/reopened issues from the previous release ticket as 'Issues to review' below.
  • check if Non-normal Release Process applies, and adapt this checklist. -> YES

Documentation

  • Changes in the docs needed? If so create issue in owncloud/docs-server.

Marketing

Build

All actions to be done on the release branch from here:

  • Bump version in info.xml (no version suffix)
  • Bump "sonar.projectVersion=" in sonar-project.properties (no version suffix)
  • Check php version dependency in info.xml
  • Check minimum ownCloud version dependency in info.xml
  • Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

  • Ping product owner to create github tag for v${version}-rc1 on release branch (see https://confluence.owncloud.com/display/EN/Product+Owners+List)
  • Build and sign RC tarball from github tag v${version}-rc1 (see handbook for how to build)
  • Upload as Github release using changelog entries
  • Test and document in testplan + manual explorative testing:
    • If this is an enterprise app: Enabling the app must start the grace period
    • Add section "Changlog Testing" using github releases text or CHANGELOG.md from release branch
    • Do changelog tests
    • Do regression tests
    • => Final "Go" from QA (set 'QA-ready' label) => else do another RC after fixing issues in the "release-$version" branch

Final

  • Check that no documentation issues are pending
  • Rename last RC tarball to final
  • Create github tag for final v${version} on release branch
  • Upload as Github release using changelog entries

No Publishing, bundled app.

Post-release

  • Add a new 'Unreleased' section in CHANGELOG.md (and also update links at the bottom!)
  • Create PR to merge changes back to the master branch with description "Closes #XYZ" with the release ticket number
  • Rename QA milestone to $version and close the milestone
  • Update https://confluence.owncloud.com/display/PROD/Upcoming+Releases
  • Ensure release template is up to date
  • Ensure the testplan template (encryption is up to date. (Links to other testplans are added without XXXX)
  • Close the testplan issue
@IljaN
Copy link
Contributor Author

IljaN commented May 23, 2022

This does not touch any risky parts of encryption, an additional option is added to a cli command.

@pako81
Copy link

pako81 commented May 23, 2022

to note that encryption is currently broken on distro coming with openSSL v3.x and needs to be manually workarounded: owncloud/core#40071 (comment)

@jnweiger jnweiger self-assigned this May 23, 2022
@jnweiger
Copy link
Contributor

Shoud we do a small release with only this fix?
Or is there something quick, we could also add concerning the ubuntu 22.04 problem?
At least a prominent message should be printed, that a required cypher is not available + some instructions as compiled in core#40071

@IljaN
Copy link
Contributor Author

IljaN commented May 23, 2022

@jnweiger imo openssl is out of scope for this one. Would probably need to be a 1.6.0 or maybe even 2.0.0 (still analyzing)

@jnweiger
Copy link
Contributor

@jnweiger jnweiger added this to the QA milestone May 25, 2022
@jnweiger
Copy link
Contributor

jnweiger commented Jun 3, 2022

Issues seen while testing

@Drezael
Copy link
Contributor

Drezael commented Jun 9, 2022

Release in the marketplace does not work because the info.xml has no "summary" field.

image

@IljaN
Copy link
Contributor Author

IljaN commented Jun 9, 2022

We probably should ask PM to come up with text.

@Drezael
Copy link
Contributor

Drezael commented Jun 9, 2022

Seems like encryption is an app that is not released in the marketplace because it is part of core. Sorry it was my mistake

@phil-davis
Copy link
Contributor

Yes, encryption is bundled in the regular "minimal" release tarball, and some other apps like configreport, firstrunwizard, market, notifications,...

And the "complete" release tarball has even more apps bundled. But that is a different beast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants