MaximumLineLength, from the "Formatting" section, is currently enabled. In the docs it says it overlaps with MaxLineLength, which we are relying on, and they have different values. Needs to be checked.

EDIT: "Formatting" section was not yet considered for this iteration, but we'll need to use the MaximumLineLength rule since it has the ignoreBackTickedIdentifier parameter, which allows to ignore the lines for the tests names with the backtick format, which we use and that currently exceed the line length limit (there is no way to break them in more than 1 line).

These reports will be avoided for the moment with @Suppress annotations, but once we enable MaximumLineLength they should be removed.

Just checked (tested empirically) with the LongMethod rule that Detekt counts LLOC when talking about lines of code, and so I guess this happens with every rule that has to do with lines of code. That means, when trying to reduce lines of code, don't play with blank lines or comments since that won't make effect 😉

Will test:

• Code smell in ownCloudApp
• Code smell in ownCloudDomain
• Code smell in ownCloudData
• Code smell in ownCloudTestUtil
• Code smell in ownCloudComLibrary
• Code smell in all modules

This is OK to go. This first iteration:

• Will have a complete set of code smells fixed, but others are pending. New issue to be created

• The execution of detekt is sequential through the app modules. If in one module are detected code smells, the execution will stop. We will check if this behaviour could be improved somehow.