Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Align file icons and colors #4483

Open
9 tasks
tbsbdr opened this issue Oct 1, 2024 · 7 comments
Open
9 tasks

[FEATURE REQUEST] Align file icons and colors #4483

tbsbdr opened this issue Oct 1, 2024 · 7 comments

Comments

@tbsbdr
Copy link

tbsbdr commented Oct 1, 2024

Problem
Icons and Icon colors are quite different between web and mobile clients. This is particularly noticeable when I e.g. do presentations, see screenshot.

screenshot_003187

Proposed solution

Align icon style and colors between web and mobile clients.

android

@JuancaG05 @jesmrec Whats you opinion - do you consider the proposal an improvement?

TASKS

  • Research (if needed)
  • Create branch feature/align_icons_and_colors
  • Development tasks
    • ...
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/align_icons_and_colors
@jesmrec
Copy link
Collaborator

jesmrec commented Oct 2, 2024

yes, that's an improvement. We just need those icons from somewhere.

@JuancaG05
Copy link
Collaborator

Hey @tbsbdr! Yes, I agree with that. But, as @jesmrec states, we need to take those icons from somewhere, since the ones we have now come from long time ago. Would be cool to have some kind of "common database" to share the same icons (we don't receive them from server, they are saved locally in the app data), also if there is any new type of file added in the future 👍

@tbsbdr
Copy link
Author

tbsbdr commented Oct 2, 2024

We could proceed like that:

  1. replace current icons with the proposed one (same as web)
  2. discuss centralised icon set (not sure if this approach will be a benefit, as clients will always need some set of local icons - tbd)

The proposed icons are taken from web, resource-type-*.svg

mabye @kulmann and team can provide more structured guidance 🙏

@JuancaG05 JuancaG05 changed the title [FR] Align file icons and colors [FEATURE REQUEST] Align file icons and colors Oct 4, 2024
@jesmrec jesmrec added this to the 4.5 - Next milestone Oct 4, 2024
@Kishubhai
Copy link

Kishubhai commented Dec 29, 2024

Issue gets solved?
@tbsbdr

@tbsbdr
Copy link
Author

tbsbdr commented Dec 31, 2024

I can not tell, @DeepDiver1975 might know or might know who can decide. (Im no longer in charge)

@joragua
Copy link
Collaborator

joragua commented Jan 10, 2025

This issue has been assigned to the team and it's in progress! 🚀 @Kishubhai if you want to contribute, take a look to issues with Contributions are welcome label. Feel free to comment if you have some questions about those issues 😄

@JuancaG05 JuancaG05 self-assigned this Jan 20, 2025
@JuancaG05
Copy link
Collaborator

Seems the provided SVG are not valid since they are rectangular, and we (and in general, mobile apps) need squared images for these icons. The vectors could be modified before introducing them into the app, making them squared, but that's not the aim here, we should keep the same resources used in other clients. This won't be implemented FTM.

@JuancaG05 JuancaG05 removed the Sprint label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants