Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart-diff: does not work correctly for draft charts #3275

Open
larsyencken opened this issue Sep 12, 2024 · 1 comment
Open

chart-diff: does not work correctly for draft charts #3275

larsyencken opened this issue Sep 12, 2024 · 1 comment

Comments

@larsyencken
Copy link
Collaborator

larsyencken commented Sep 12, 2024

Problem

The chart diff flow hasn't been designed for draft charts, so lingering draft charts can cause it to crash.

Expected behaviour

Draft charts should also be queued for approval, like other charts.

Workaround

We currently ignore draft charts in the chart diff.

@larsyencken larsyencken changed the title chart-diff does not work correctly for draft charts chart-diff: does not work correctly for draft charts Sep 12, 2024
@larsyencken
Copy link
Collaborator Author

We triaged this as "important" since you might expect that your work as draft charts would be shipped, but instead you could lose that work after merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant