New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch on validation of encrypted ciphertexts #87

Open

eversC opened this issue Jul 19, 2019 · 0 comments

Collaborator

eversC commented Jul 19, 2019

...right now this would only apply to keys stored in GitHub, as that's the only time encryption is needed.

ovotech/mantle has the ability to validate ciphertexts for us, so we'd just need to switch it on here:

cloud-key-rotator/pkg/crypt/crypt.go

Line 30 in b1aae8e

const disableValidation = true

I can't remember the original reason why this was disabled, so thorough testing required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment