Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import f202839ffc: broke textureCache during revert; fixed (by Caitlyn) #420

Open
daleglass opened this issue Aug 5, 2022 · 0 comments
Open
Labels
automanaged Managed by a bot. Title and body are overwritten. Tags may be modified.

Comments

@daleglass
Copy link

This is an automated proposal to look at a commit made by Caitlyn and import it into Overte

Commit: f202839
Author: Caitlyn
Date: Tue, 05 May 2020 14:01
broke textureCache during revert; fixed


Stats:

Filename Stats Lines Added Removed Lines in blame
libraries/qml/src/qml/impl/TextureCache.cpp 1429 121 1308 121
libraries/qml/src/qml/impl/TextureCache.h 283 53 230 53
2 files - 1712 174 1538 174

To work on this, please assign the issue to yourself, then look at the commit and decide whether this would be a good addition to Overte.

  • If the commit is useful, tag it with "Tivoli: Keep", and keep it open until it's merged.
  • If the commit is not useful, tag it with "Tivoli: Discard", and close it.
  • If the commit is not useful right now, but might be later, tag it with "Tivoli: Maybe later", and close it.
  • If it's hard to decide, tag it with "Tivoli: Discuss", and keep it open.

Useful commits should be submitted as a PR against Overte. Tag this issue in PR, so that it's automatically closed once the PR is merged.

You can cherry-pick this issue with this command:

git cherry-pick f202839ffc7918d26b43d5587a6432a7010349ca
@daleglass daleglass added the automanaged Managed by a bot. Title and body are overwritten. Tags may be modified. label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automanaged Managed by a bot. Title and body are overwritten. Tags may be modified.
Projects
None yet
Development

No branches or pull requests

1 participant