Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cachebusting based on HTTP headers #638

Open
ksuprynowicz opened this issue Sep 20, 2023 · 4 comments
Open

Add cachebusting based on HTTP headers #638

ksuprynowicz opened this issue Sep 20, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@ksuprynowicz
Copy link
Member

Right now caching is too aggressive and things header like this could be used:

HTTP/1.1 200 OK
Content-Type: text/html
Content-Length: 1024
Date: Tue, 22 Feb 2022 22:22:22 GMT
Last-Modified: Tue, 22 Feb 2021 22:22:22 GMT

More about caching:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching#heuristic_caching

@ksuprynowicz ksuprynowicz added the enhancement New feature or request label Sep 20, 2023
@gydence
Copy link

gydence commented Sep 21, 2023

this PR was supposed to help with this: vircadia/vircadia-native-core#1012

specifically, using PreferNetwork instead of PreferCache (and also, we’re not setting up the cache properly): https://github.com/vircadia/vircadia/pull/1012/files#diff-68a2781d62fbafa8031b8ce01cbf7cc0541197f7e1616805ecaa8693dedaa3c8R61

@vegaslon
Copy link
Contributor

I thought that had already been merged.

@gydence
Copy link

gydence commented Sep 21, 2023

nope, there were mixed reports of if it worked or not and I never got a chance to take another look.

@ksuprynowicz
Copy link
Member Author

It looks like we already record the last modified date in the cached files so this shouldn't be too difficult

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants