Replies: 29 comments 29 replies
-
uint32_t audio_ssrc; 还有这四个,移动到generate_sdp_offer里面 |
Beta Was this translation helpful? Give feedback.
-
RTCContext *rtc = s->priv_data;
没必要强行转换,是不是在声明变量的时候就可以unsigned char *, 后边的strlen也一样,不需要要强行int |
Beta Was this translation helpful? Give feedback.
-
av_freep(&rtc->ice_ufrag_remote); 这里的几个有必要av_freep先释放不? |
Beta Was this translation helpful? Give feedback.
-
av_freep(&rtc->ice_protocol); 这些av_freep是不是可以提成一个函数,然后在进入这个函数后第一步先清理一下。 |
Beta Was this translation helpful? Give feedback.
-
char ice_ufrag_local[9]; 这两个变量放到generate_sdp_offer函数里面作为局部变量是不是也可以? |
Beta Was this translation helpful? Give feedback.
-
av_freep(&rtc->ice_protocol); 添加一个if (!rtc->ice_host) 的mem alloc判断,如果异常的话需要释放掉前面申请的所有资源,并且返回ENOMEM |
Beta Was this translation helpful? Give feedback.
-
static int rtc_write_trailer(AVFormatContext *s) Will this function be used? |
Beta Was this translation helpful? Give feedback.
-
can these controlled by options? |
Beta Was this translation helpful? Give feedback.
-
add memory alloc failed check and give failed message when it failed. |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
should add http.o if rtcenc.o will use http.o functions. |
Beta Was this translation helpful? Give feedback.
-
typo? |
Beta Was this translation helpful? Give feedback.
-
memory alloc check |
Beta Was this translation helpful? Give feedback.
-
Should av_freep(&rtc->avc_sps) here? |
Beta Was this translation helpful? Give feedback.
-
Can this replaced by av_bprint ? |
Beta Was this translation helpful? Give feedback.
-
two nouse line |
Beta Was this translation helpful? Give feedback.
-
I think you can remove these two line by some ways. |
Beta Was this translation helpful? Give feedback.
-
是不是跟上面的ifndef可以搞成else的方式 |
Beta Was this translation helpful? Give feedback.
-
头文件引用的是不是带目录的是一坨,不带目录的是一坨,排序一坨 |
Beta Was this translation helpful? Give feedback.
-
这几个new需要check失败不 |
Beta Was this translation helpful? Give feedback.
-
如果只是一条语句,是不是可以没有{} |
Beta Was this translation helpful? Give feedback.
-
是不是可以先undefined,然后这里再if else,可以节省一次else |
Beta Was this translation helpful? Give feedback.
-
ditoo |
Beta Was this translation helpful? Give feedback.
-
ditoo |
Beta Was this translation helpful? Give feedback.
-
不必要的大括号 |
Beta Was this translation helpful? Give feedback.
-
没啥用的可以删掉 |
Beta Was this translation helpful? Give feedback.
-
This should be removed, because this file should be enabled if CONFIG_OPENSSL is true when configure |
Beta Was this translation helpful? Give feedback.
-
add descriptions of the options into doc/muxer.texi |
Beta Was this translation helpful? Give feedback.
-
Can libavformat/avc.c replace this function? |
Beta Was this translation helpful? Give feedback.
-
Review for #1
Beta Was this translation helpful? Give feedback.
All reactions