Fixes #170 #171
Open
Fixes #170 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wheresreligion ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for animated-kangaroo-b914c6 failed.
|
jwang-101
reviewed
Nov 11, 2024
| ); | ||
| } | ||
|
|
||
| test('search bar ref is assigned to the correct search bar element', () => { |
There was a problem hiding this comment.
test case looks good, properly references the search bar with jest mock
| <div | ||
| className="flex flex-row w-[30vw] left-0 z-10 m-5 align-center items-center" | ||
| className="flex flex-row w-[30vw] left-0 z-10 m-5 align-center items-center"> |
There was a problem hiding this comment.
this seems like a better placement for the pop up size on the search bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. PR Reference
Fixes #170
2. What was changed:
Updating the introjs to enhance visual appeal by adjusting the popup's design for the search bar specifically, adding functionality to ensure the tour shows only once per user, and making sure all test cases still pass after changes
3. Why it was changed:
This update improves user experience by refining the search bars' popup aesthetics and functionality, making the tour both visually appealing and non-intrusive. This update also helps avoid redundant interruptions by making the tour only appears once per user.
4. How it was changed:
UI update:
The search bar reference was moved to a different css container so that the intro popup will point to a better reference for the search bar
Tour Display Logic:
The tour shows up only once per user by implementing a “do not show again” button.
If a user has already completed or skipped the tour, it will not appear again in future sessions.
Testing:
Writing test case for making sure the new css container shows up properly.
Making sure all previous tests still pass. (regression testing)