Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

largest cycle in statistics not being computed correctly #167

Open
2 tasks
suprajamannava17 opened this issue Oct 22, 2024 · 0 comments · May be fixed by #176
Open
2 tasks

largest cycle in statistics not being computed correctly #167

suprajamannava17 opened this issue Oct 22, 2024 · 0 comments · May be fixed by #176
Assignees

Comments

@suprajamannava17
Copy link
Collaborator

suprajamannava17 commented Oct 22, 2024

Overview:
There are several issues with the current statistics calculations on the application, particularly regarding the largest cycle, preperiodic cardinality, average resultant, and PC set values. These metrics are not computed or displayed accurately, leading to inconsistent data presentation and reduced user confidence in the data reliability. This issue aims to address these errors by adjusting the calculations for these metrics to align with the expected definitions and correct any discrepancies in data output.

Tasks:

  1. Correct Largest Cycle Calculation:
  • Update the calculation for largest cycle to reflect the maximum of the cycle lengths (periodic_cycles in the graph table), rather than the maximum of the cardinality.
  • Verify that the updated calculation accurately displays the largest cycle length for each record.
  1. Fix Preperiodic Cardinality Calculation:
  • Adjust the preperiodic cardinality calculation to return the correct values.
  • Example Issue: In the search for aut group card: 3, only one map is returned,
    1.7e1406dd.6d8da028.1 P1 → P1 4 [x4-8xy3 : 4x3y+4y4] 1.1.1.1
    with preperiodic cardinality listed incorrectly as 2 instead of 4.

Expected Behavior:
The statistics for the largest cycle and preperiodic cardinality should reflect accurate calculations as per the intended definitions. These metrics should be displayed correctly and consistently for each record in the graph table and rational preperiodic filter.

Acceptance Criteria:

  • Largest Cycle displays the maximum of cycle lengths (periodic_cycles in the graph table) for each record, not the max of the cardinality.
  • Preperiodic Cardinality displays accurately, including edge cases where previous calculations showed discrepancies.
@suprajamannava17 suprajamannava17 changed the title largest cycle is statistics not being computed correctly largest cycle in statistics not being computed correctly Oct 22, 2024
@dracpak dracpak assigned dracpak and unassigned dracpak Oct 22, 2024
@dracpak dracpak self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants