-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM support for Gazebo Images #173
Comments
@odidev , as from a previous comment #171 (comment) , may I inquire your use case or applications that necessitating containerised gazebo on arm? I'm not against this, but I would first like to be informed of the use cases we would then attempt to support. |
@ruffsl : Thanks for taking some time for this issue. I can't advocate much about this. But yes for sure what I can say is that now paradigm is moving towards ARM architecture and with the market moving a lot towards 64-bit processors, it is high time that there is a good increase in demand for arm64 based applications and projects. In this way, the clients who are sceptical just because of the lack of support for this application on ARM64 will also gain the confidence to use this without any issue. Moreover, what I notice is that Gazebo is already supported by |
I was looking at the package index for gazebo, and I'm not seeing any ping @j-rivero or @nuclearsandwich |
Gazebo9 is upstream on ubuntu bionic. The current release strategy for Gazebo is that minor releases are not built for arm (only i386 and amd64). If a project requires arm packages to be built, we build some, but it is not the default. It could be done if there is a strong incentive / use case requiring arm packages but currently is not done as it adds a lot of build time on the farm. Edit: If we want to provide Gazebo ARM images, I think that the best way ATM is to allow having different version numbers per architecture and to use the version available in the official ubuntu repos for the arm platforms (MAJOR.0.0). And to not provide ARM images for the distros that don't have that major upstream. |
Thank you all for taking out some time to look for ARM64 support for Gazebo. Regards, |
@mikaelarguedas So could you then do something like others have for the major releases to support arm64v8 on those versions published? Gradle for example: Tags: 4.9.0-jdk7-alpine, 4.9-jdk7-alpine, jdk7-alpine Tags: 4.9.0-jdk7-slim, 4.9-jdk7-slim, jdk7-slim Thank you. |
@mmarmm This looks like a different question as alpine is not targeted by any existing ROS or Gazebo distribution. Could you please open a separate issue clarifying what project you are interested in ? Thanks |
@mikaelarguedas "... If we want to provide Gazebo ARM images, I think that the best way ATM is to allow having different version numbers per architecture ...", that's what I was responding to, apologies I wasn't clear. I'm suggesting adding arm64v8 builds for only the major release, not for all since the minor releases pose a burden. |
Thanks @mmarmm for clarifying! The issue we are facing is that we currently use the same dockerfile for all architectures. So there is no easy way to "adding arm64v8 builds for only the major release, not for all" as we do want all (including minor) releases for amd64. It looks like what you are suggesting is another set of Dockerfiles for specific architectures, is that correct? (similar to prototype in #115) The alternative is to provide logic within the dockerfiles to install different packages depending on the arch and what's available in the repos for that arch (#112 (comment)) The various otpions are discussed in more detail on #112 |
I'm really, really confused here. Why is Regarding a separate |
It seems that the main reason behind it was that originally Gazebo was shipped only for amd64. An initial release was made on arm to support the platforms targeted by specific ROS distributions but new arm packages are built on an cc @j-rivero |
We are adding support to our internal release process to produce the whole family of arches for Ubuntu and Debian stretch. That should happen in the next weeks. |
@j-rivero the prospect of this is very exciting. Could I bother you for an update on your progress please? |
Sure, no problem. The code is ready, should be reviewed and merged. From that point on, all the releases should try to build ARM and Debian Stretch. |
That is an awesome update @j-rivero . |
@j-rivero you sir, are a star. 👍 |
Hi @j-rivero After the changes get merged, it will require a modification at: Can you raise a Pull Request for it as well, after merge confirmation? Regards, |
Please see #203 |
Update: please now see #205 |
Thanks @ruffsl. Reviewed. |
Wonderful. Thanks @ruffsl. |
Gazebo9 is supported by
Debian:Stretch
for bothAMD64 & ARM64
architecture.I have done changes at my end in
manifest.yaml
to support Gazebo forARM64
architecture.I would be happy to raise a PR if it suits maintainers.
The text was updated successfully, but these errors were encountered: