Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken PolicyBrain prior-run links #695

Open
MattHJensen opened this issue Oct 10, 2017 · 2 comments
Open

Broken PolicyBrain prior-run links #695

MattHJensen opened this issue Oct 10, 2017 · 2 comments

Comments

@MattHJensen
Copy link
Contributor

It appears that a recent PolicyBrain update broke old CCC links. I should be able to go to ospc.org/ccc/800, for example, and see results, but instead I get a 500 internal server error. Similarly, I should be able to go to http://www.ospc.org/ccc/edit/800/ and see the parameter changes that resulted in ospc.org/ccc/800.

We do not need to ensure that users can re-run old simulations, but they should be able to see their results, the inputs that generated, and the version of PolicyBrain that they used. With this information and some work, it should be possible to replicate analyses locally.

Whether or not it is possible to fix this problem now, we should have some tests that protect links in the future and to document that this is a PolicyBrain requirement.

@MattHJensen MattHJensen changed the title Broken PolicyBrain input/output links Broken PolicyBrain links Oct 10, 2017
@MattHJensen MattHJensen changed the title Broken PolicyBrain links Broken PolicyBrain prior-run links Oct 10, 2017
@hdoupe
Copy link
Collaborator

hdoupe commented Oct 10, 2017

@MattHJensen It looks like the edit page is working fine. I'm not sure what's going on with the results page. I'll look into this.

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 14, 2017

It looks like this capability works back to run 877 which occurred on the same day as PolicyBrain release 1.0.3. This was the release where we started using the bokeh plot for the CCC. B-Tax had to be updated in order to return the required data for this plot. Thus, when we try to load an earlier CCC run, we are unable to parse the results.

Note that the user can got to the edit page, http://www.ospc.org/ccc/edit/800/, and re-run the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants