Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total track statistic in folder footer #3533

Closed
6 tasks done
dmpr0 opened this issue Mar 28, 2024 · 14 comments · Fixed by #3944, #4076 or #4101 · May be fixed by #4102
Closed
6 tasks done

Total track statistic in folder footer #3533

dmpr0 opened this issue Mar 28, 2024 · 14 comments · Fixed by #3944, #4076 or #4101 · May be fixed by #4102
Assignees
Milestone

Comments

@dmpr0
Copy link
Contributor

dmpr0 commented Mar 28, 2024

Description

Android task osmandapp/OsmAnd#14673

ToDo

Add total track stars below list of tracks in all subfolders.

Tracks – 4, distance – 246.6 km, uphill – 325 m, downhill – 456 m, duration – 08:50:35, size – 14 MB.

  • Tracks quantity in folder
  • Total sum of distance
  • Total sum of uphill
  • Total sum of downhill
  • Total sum of duration
  • Total size in MB
@vshcherb vshcherb added this to the 4.8-iOS milestone Apr 1, 2024
@nnngrach nnngrach assigned nnngrach and unassigned nnngrach May 9, 2024
@vshcherb vshcherb modified the milestones: 4.8-iOS, 4.9-iOS Jun 20, 2024
@DmitrySvetlichny DmitrySvetlichny self-assigned this Aug 20, 2024
@DmitrySvetlichny
Copy link
Contributor

#3944

@DmitrySvetlichny DmitrySvetlichny linked a pull request Aug 22, 2024 that will close this issue
@vshcherb vshcherb reopened this Aug 27, 2024
@tigrim tigrim assigned tigrim and unassigned DmitrySvetlichny Aug 28, 2024
@tigrim
Copy link
Contributor

tigrim commented Aug 29, 2024

When using OsmAndShared in Objective-C files, to access class methods and properties, you need to use the import statement:

#import <OsmAndShared/OsmAndShared.h>

OASGpxFile *gpxFileKotlin = [KSharedUtil loadGpx:@""];
NSLog(@"%@", gpxFileKotlin.author);

However, during compilation, we encounter an error as shown in the image:

Image

The assumption is that in build.gradle.kts for iosMain.dependencies, an alternative to implementation("com.squareup.okio:okio:$okioVersion") should be used, as they are not compatible.

@dmpr0
Copy link
Contributor Author

dmpr0 commented Oct 30, 2024

Review

Screenshot
  • Missed on Tracks (Main folder)

Screenshot

@dmpr0 dmpr0 reopened this Oct 30, 2024
@Skalii

This comment has been minimized.

@DmitryAlexei
Copy link

Only bugs related to the total track statistic issue are left in this task.
Other bugs are transferred into a new issue - https://github.com/osmandapp/OsmAnd-Issues/issues/2764

@DmitrySvetlichny DmitrySvetlichny self-assigned this Oct 31, 2024
@DmitrySvetlichny
Copy link
Contributor

#4101

@DmitrySvetlichny DmitrySvetlichny linked a pull request Nov 5, 2024 that will close this issue
@DmitrySvetlichny
Copy link
Contributor

#4102

@DmitrySvetlichny DmitrySvetlichny linked a pull request Nov 5, 2024 that will close this issue
@tigrim tigrim removed their assignment Nov 8, 2024
@DmitryAlexei
Copy link

DmitryAlexei commented Nov 12, 2024

Remains

  • Different stats. Probably the issue is in the library. Total distance without gaps

@DmitrySvetlichny
Copy link
Contributor

The primary issue under the item "Different stats" is that the values of diffElevationUp and diffElevationDown differ for segmented tracks, depending on how GpxTrackAnalysis is initialized. When initialized with getGeneralSegment, the values differ from initialization per each segment (https://github.com/osmandapp/OsmAnd-iOS/pull/4102/files). Initializing per each segment yields results that match the information in getFolderAnalysis. However, it does not record information in totalDistanceWithoutGaps, which is used in the UI to display the total distance for segmented tracks.

@DmitrySvetlichny
Copy link
Contributor

Fixes did not solve the problem "Different stats. Only one track in folder. Track EuroVelo 6 - developed 2.gpx.zip"

@vshcherb
Copy link
Member

vshcherb commented Jan 9, 2025

For testing:

  • Fixes for distance for join segments done in master - osmandapp/OsmAnd@45299cd
  • Difference uphill / downhill (present in Android for track EuroVelo6) - separate issue should be created. On graph 10 430 m, 10 507 m (in overview and in My places). Join segments doesn't update screen for uphill downhill. iOS has same issue.
  • iOS doesn't have switch on / off join segments - separate task
  • Test that track with join segments on parameter is transferred from Android to iOS via Track export
  • Bug Android: join segments on - distance is not updated in Track overview and in My places Fix recalculating statistics when changing parameters OsmAnd#21767

@vshcherb vshcherb closed this as completed Jan 9, 2025
@vshcherb vshcherb modified the milestones: 4.9-iOS, 5.0-iOS Jan 13, 2025
@vshcherb vshcherb reopened this Jan 13, 2025
@alex-osm
Copy link
Contributor

osmandapp/OsmAnd#21767

@Zirochkabila
Copy link
Collaborator

Zirochkabila commented Jan 27, 2025

Test 1

4.9.5.4959 - Fixed

@vshcherb vshcherb reopened this Jan 28, 2025
@DmitryAlexei DmitryAlexei reopened this Jan 30, 2025
@Zirochkabila
Copy link
Collaborator

Testing 2

4.9.5.4960

  1. iOS doesn't have switch on / off join segments - It does, but it is located elsewhere.
    Should I leave it as it is or create a task to transfer the function (to the same place as in Android)? @vshcherb
Switch

  1. Test that track with join segments on parameter is transferred from Android to iOS via Track export - 4341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment