From d6b79c35c9ca2c79f804b064db3e29c21a801793 Mon Sep 17 00:00:00 2001 From: Aulon Mujaj Date: Wed, 29 Dec 2021 12:56:44 +0100 Subject: [PATCH 1/5] Update CODE_OF_CONDUCT.md --- CODE_OF_CONDUCT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md index d639937c8..c5abe0326 100644 --- a/CODE_OF_CONDUCT.md +++ b/CODE_OF_CONDUCT.md @@ -55,7 +55,7 @@ further defined and clarified by project maintainers. ## Enforcement Instances of abusive, harassing, or otherwise unacceptable behavior may be -reported by contacting the project team at aulon.mujaj@origo.oslo.kommune.no. All +reported by contacting the project team at dataspeilet@oslo.kommune.no. All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. From b9fa6fe850f402d79be905b8fb49ce50915def61 Mon Sep 17 00:00:00 2001 From: Aulon Mujaj Date: Thu, 30 Dec 2021 11:45:32 +0100 Subject: [PATCH 2/5] fix(design): fixed hover colors, theme colors on line charts and header title disappearing --- CHANGELOG.md | 9 +++ src/components/ActionBar.vue | 3 +- src/components/KeyResultRow.vue | 7 ++- src/components/KpiLink.vue | 3 +- src/components/Navigation/SiteHeader.vue | 76 +++++++++++++++++++++-- src/components/Navigation/SiteSidebar.vue | 27 ++++---- src/components/widgets/WidgetAdmin.vue | 4 +- src/components/widgets/WidgetWeights.vue | 5 +- src/styles/_alerts.scss | 1 + src/styles/_buttons.scss | 2 +- src/styles/_forms.scss | 3 + src/styles/_miller.scss | 2 +- src/styles/_tabs.scss | 8 +-- src/styles/_widgets.scss | 5 +- src/styles/main.scss | 14 +++-- src/styles/ods/ods-forms.scss | 2 + src/util/LineChart/index.js | 15 +++-- src/util/LineChart/linechart-helpers.js | 35 +++++++++-- src/views/Home.vue | 24 +++---- src/views/ItemAdmin/ItemAdminKPI.vue | 2 +- src/views/ItemAdmin/ItemAdminWrapper.vue | 8 +-- src/views/KeyResultHome.vue | 45 ++++++++++++-- src/views/KpiHome.vue | 17 ++--- src/views/Login.vue | 2 +- 24 files changed, 236 insertions(+), 83 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 32e1f4802..b353137c8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file. The format ## [UNRELEASED] +### Changes + +- Use the only blue hover color the Oslo design system has to offer on both green and blue themes +- Line chart changes colors together with the theme + +### Fixed + +- Header title disappeared when opening the side drawer + ## [2.7.0] 2021-12-29 OKR-tracker has been redesigned! diff --git a/src/components/ActionBar.vue b/src/components/ActionBar.vue index f999c4489..5281c1348 100644 --- a/src/components/ActionBar.vue +++ b/src/components/ActionBar.vue @@ -58,7 +58,7 @@ export default { .action-bar__period-dates { margin-bottom: 1.5rem; - color: var(--color-grey-700); + color: var(--color-primary); font-size: 0.9em; @media screen and (min-width: bp(s)) { @@ -68,6 +68,7 @@ export default { } .action-bar__view { + color: var(--color-primary); font-weight: 500; background: none; border: none; diff --git a/src/components/KeyResultRow.vue b/src/components/KeyResultRow.vue index 1f19e8d30..bae40a735 100644 --- a/src/components/KeyResultRow.vue +++ b/src/components/KeyResultRow.vue @@ -132,7 +132,8 @@ export default { background-color: var(--color-secondary-light); &:hover { - background-color: var(--color-secondary); + color: var(--color-text-secondary); + background-color: var(--color-hover); } } @@ -142,7 +143,7 @@ export default { .keyResult__info--header { height: 100%; - color: var(--color-grey-800); + color: var(--color-text); text-decoration: none; } @@ -165,7 +166,7 @@ export default { } &:hover { - background-color: var(--color-primary-dark); + background-color: var(--color-hover); cursor: pointer; } } diff --git a/src/components/KpiLink.vue b/src/components/KpiLink.vue index 6d9e50e5b..233fd3938 100644 --- a/src/components/KpiLink.vue +++ b/src/components/KpiLink.vue @@ -71,7 +71,8 @@ export default { background: var(--color-secondary-light); &:hover { - background: var(--color-secondary); + color: var(--color-text-secondary); + background: var(--color-hover); } &.disabled { diff --git a/src/components/Navigation/SiteHeader.vue b/src/components/Navigation/SiteHeader.vue index cf334666a..cdc9a7af9 100644 --- a/src/components/Navigation/SiteHeader.vue +++ b/src/components/Navigation/SiteHeader.vue @@ -1,8 +1,13 @@