Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Highlighting #434

Open
znschaffer opened this issue Sep 17, 2024 · 5 comments · May be fixed by #435
Open

Weird Highlighting #434

znschaffer opened this issue Sep 17, 2024 · 5 comments · May be fixed by #435

Comments

@znschaffer
Copy link
Contributor

my nick is znschaffer yet tiny keeps on highlighting YouTube links bizarrely.

image

I'm not sure what in the regex for nick's would cause this but it's mighty annoying

@osa1
Copy link
Owner

osa1 commented Sep 17, 2024

This is probably an IRC color code to show the "Tube" part in red background, similar to the old logos here: https://logos-world.net/youtube-logo/ (scroll to "Meaning and History").

It looks like either the colored part is not terminated, or it is terminated but we don't handle the termination code properly.

Have you checked if these messages look as expected in other clients?

Which server/channel is this? Maybe I (or someone else) can join and debug this.

@osa1
Copy link
Owner

osa1 commented Sep 17, 2024

@znschaffer could you try #435 and let me know if it fixes the issue?

@znschaffer
Copy link
Contributor Author

oh my! i never would've thought it was added in w/ escape codes to replicate the old logomark. trying this patch now

@znschaffer
Copy link
Contributor Author

image cheers! @osa1

@osa1
Copy link
Owner

osa1 commented Sep 17, 2024

That's better, but it still doesn't look right. The part after "Tube" looks bold now. Is this expected? Is it how it looks like in other clients?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants