You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As far as I can see the gem was not updated for over 1 year and it seems it's not compatible with Spree 4.5 at the moment. Although I did a few updates to fix that (spree-contrib/spree_related_products#200)
Anyway, do you think the code from core (and ideally from legacy frontend too) should be moved into the gem? Or is there a reason this code would be in spree code? The db migrations are in the gem and not in spree core, so it makes little sense to me.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I'm not sure if you are aware but there is quite a bit of code related to this gem:
https://github.com/spree-contrib/spree_related_products
inside spree core, for example:
https://github.com/spree/spree/blob/main/core/app/helpers/spree/products_helper.rb#L122
And also in spree_legacy_frontend.
As far as I can see the gem was not updated for over 1 year and it seems it's not compatible with Spree 4.5 at the moment. Although I did a few updates to fix that (spree-contrib/spree_related_products#200)
Anyway, do you think the code from core (and ideally from legacy frontend too) should be moved into the gem? Or is there a reason this code would be in spree code? The db migrations are in the gem and not in spree core, so it makes little sense to me.
Beta Was this translation helpful? Give feedback.
All reactions