Faulty char != -1 check in OracleDialectRules.QStringRule.doEvaluate

[Marcono1234]

Description

OracleDialectRules.QStringRule.doEvaluate contains the following check:

dbeaver/plugins/org.jkiss.dbeaver.ext.oracle/src/org/jkiss/dbeaver/ext/oracle/sql/OracleDialectRules.java

Line 55 in 0642e8c

if (resume && quoteStartChar != -1) {

The problem is that quoteStartChar is a char and the minimum value of char is 0, so the != -1 check will always be true.

Maybe the simplest solution is to change quoteStartChar to type int and remove the char cast.

I am not planning to submit a pull request though because I am not familiar with this project.

DBeaver Version

commit 0642e8c

Operating System

No response

Database and driver

No response

Steps to reproduce

No response

Additional context

No response

[E1izabeth]

Have you meet some bug? What issue are you trying to solve?

[E1izabeth]

Anyway, thank you for interest to our project and finding a flaw.

[Marcono1234]

No sorry I haven't investigated the exact consequences of this bug. I was investigating this general bug pattern when I stumbled upon it in your repository and thought it would at least be useful to let you know about it, because it has for sure some (negative) consequence.

[Marcono1234]

For future reference, it looks like this was fixed by #20151