Interesting psalm error.

[sicet7]

Hi all, I have run into an interesting psalm error.

I get the following error:

ERROR: InvalidArgument - FailedQueueJob.php:18:21 - Argument 1 of Cycle\Annotated\Annotation\Entity::__construct expects class-string<Cycle\ORM\RepositoryInterface<object>>|null, but FailedQueueJobRepository::class provided (see https://psalm.dev/004)
        repository: FailedQueueJobRepository::class

I run on cycle/orm version 2.9.2

The reason that is interesting is in need of more context, so here is the relevant classes and interfaces, stripped of their implementation to bring into view the issue I am having.

use Cycle\ORM\RepositoryInterface;
use Cycle\Annotated\Annotation\Entity;

/**
 * @template TEntity
 * @extends RepositoryInterface<TEntity>
 */
interface ExtendedRepositoryInterface extends RepositoryInterface
{
    //... methods here.
}

/**
 * @template TEntity
 * @implements ExtendedRepositoryInterface<TEntity>
 */
abstract class AbstractRepository implements ExtendedRepositoryInterface
{
    //... methods here.
}

/**
 * @extends ExtendedRepositoryInterface<FailedQueueJobInterface>
 */
interface FailedQueueJobRepositoryInterface extends ExtendedRepositoryInterface
{
    //... methods here.
}

interface FailedQueueJobInterface
{
    //... methods here.
}

#[Entity(
    repository: FailedQueueJobRepository::class,
    table: 'v4_failed_queue_jobs',
)]
class FailedQueueJob implements FailedQueueJobInterface
{
    //... methods here.
}

/**
 * @extends AbstractRepository<FailedQueueJob>
 */
final class FailedQueueJobRepository extends AbstractRepository implements FailedQueueJobRepositoryInterface
{
    //... methods here.
}

I have found 3 solutions to my problem:

1. Change the annotation on the FailedQueueJobRepositoryInterface interface from @extends ExtendedRepositoryInterface<FailedQueueJobInterface> to @extends ExtendedRepositoryInterface<object>

• I don't like this solution because i lose my type "safety" in my implementing class.

2. Change the annotation on the Cycle\Annotated\Annotation\Entity attribute from @param class-string<Repository>|null $repository to @param class-string|null $repository

• This is in the dependency aka. in the vendor directory which means a patch or pull request to upstream, but i also don't like this as it removes type "safety".

3. Change the annotation on the Cycle\ORM\RepositoryInterface interface from @template TEntity of object to @template TEntity

• This is also in the dependency aka. the vendor directory which also means a patch or pull request to upstream.

So my question(s) are:
What should I do?
To me option 3 seems like the better option but only for the reason that I fail to see the reason why the of object is there in the first place? what value does it add? what am I missing?

Is there another solution that I am missing?

[roxblnfk]

Let's try the option 3.
For me, of object means "an instance of any class (not an int or string)." This is not @template-covariant, and you can narrow object down to any specific class. However, this breaks in the case of a parameter where you can only extend the type.

[sicet7]

@roxblnfk thanks for the quick reply i have created the following PR: #508
I will mark this a the answer and then we can just continue the discussion on the PR :-)

[roxblnfk]

v2.9.3 with the fix has been released. Thanks for the contribution 👍