Looking for TypeScript reviewers

[eliandoran]

Hello, @TriliumNext/everyone .

As I have already started a bit working on porting the backend to TypeScript, I need TypeScript guys to review my code.

If you have experience with TypeScript, write a comment here and I will create a team containing only you that we can assign for reviews (and potentially development later on).

[zerebos]

I will try to take a look when I have some time, but my TypeScript skills are not the best, I generally stick to more simple types (according to TypeScript experts) since it does the task at hand.

[ProfDoof]

I'm not an expert on typescript in particular but I'm fairly comfortable with most type systems at this point and am more than happy to look at it. I also have a few friends who are typescript gurus that I can ping to get second opinions on things.

[eliandoran]

@rauenzi , @ProfDoof , I would appreciate a review on the conversion PRs I have started: #13, #18, #25

[eliandoran]

@TriliumNext/everyone , could anyone else help with reviews for the TypeScript conversion PRs, please?
i would really like to move forward with the TypeScript conversion.

[Micosilent]

I left some comments in the #25 PR, I did not leave a proper code review, but did look at all the code and found it good.

[meichthys]

Also See #157

[eliandoran]

@TriliumNext/development , I am reopening a bit this discussion since it's an important topic for me.

Personally I feel that development is currently going a bit faster than the reviews. I had a few PRs that were unreviewed for a few days. I know that people are busy, but we should really decide on approach that does not reduce efficiency or cause any potential frustrations.

For some PRs this has caused me to merge some PRs without review, since they were needed for the upcoming release or no consensus was reached.

Maybe it's an over-expectation from me since I am accustomed to next-day reviews maximum as part of my job.

cc. @root-hal9000 , @rauenzi

[meichthys]

I think a new logo and some slight UI improvements that you have been discussing (perhaps to the mobile interface too) would be enough for the first public release. I've seen 'next-gen' releases of many projects that have been nothing more than a name change and some new marketing flare.

[JYC333]

It's my first time joining an open source project, and my feeling is that someone need to push a bit harder to get things done.

Regarding "as the changes are something everyone is on the same page", I think we'd have a hard time aligning everyone on everything. And then comes the philosophical question: if there's only a handful of developers, why should they cater to everyone's opinions when they can do what they want?

And I also agree on this, as long as the main direction is aligned, technical details shouldn't be too much important if there are no breaking changes. I may not have time to develop features recently, but I'll try my best to help reviewing and unblocking for the development @eliandoran . I believe the free time and the willness of putting time on this project for everyone is varying alone the time. As long as some of us could unblock the development, I think it's better to get things done before the developers losing their passions.

[zerebos]

Maybe go for Rust instead of Go.

Can I ask why? I find Go to be much nicer to work with and Rust to be overkill for something that isn't an embedded system.

But regardless, since there are multiple teams involved, we still need a lead to give a general direction of the application. I think a lot of time is spent on the org discussing, rather than getting things done.

Yeah this was kinda more my point, someone making the high level calls is great and the "being on the same page" should be done at the same high level. Like I shouldn't be able to just stop your work because of my personal preference, but if I bring forward a good reason to not go in a certain direction then I think that should be discussed.

[eliandoran]

@meichthys ,

Then we should get started. 💪🏻

Either way, we need to resume the discussion about the logos. I'll start a new poll.

@JYC333 , thanks.

Can I ask why? I find Go to be much nicer to work with and Rust to be overkill for something that isn't an embedded system.

Honestly I can't say I have much experience with Go, I contributed really small fixes to a few projects and I can't say I'm a fan of the syntax. I worked only a bit with Rust but I really appreciated the strictness of the compiler. Sometimes I feel that TypeScript is not strict enough, especially in regards with exception checking.

My "final boss" would be adding full support to mobile (that is not just client, but also server). I feel that if we are going to do it in Rust or Go it's going to be more difficult.

Yeah this was kinda more my point, someone making the high level calls is great and the "being on the same page" should be done at the same high level

I'm glad that we're aligned on this.

[zerebos]

and I can't say I'm a fan of the syntax.

Fair and oddly enough I feel the same way about Rust. Let's settle on Zig instead 😉

My "final boss" would be adding full support to mobile (that is not just client, but also server). I feel that if we are going to do it in Rust or Go it's going to be more difficult.

Time to move everything to dart/flutter 😄