Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow xhr options to be passed (e.g., withCredentials) #52

Open
parente opened this issue Oct 1, 2015 · 0 comments
Open

Allow xhr options to be passed (e.g., withCredentials) #52

parente opened this issue Oct 1, 2015 · 0 comments

Comments

@parente
Copy link

parente commented Oct 1, 2015

This issue (and a few others I'm going to open) are born out of our experience so far using Thebe for the https://github.com/jupyter-incubator/dashboards prototype. You could easily tell me "it's out of scope" for Thebe and I'll believe you, but I figured I would report it. :)

If I want to run my kernel provider (e.g., tmpnb) behind a proxy that, for example, requires auth headers to be sent along with XHR requests, I have to hack the code to set the withCredentials flag. Likewise, if I have a setup in which I need to send additional headers, I have to hack the code. It would be nice if these comm options could be set without touching Thebe.

Of course, I recognize that the code pulled from jupyter/notebook doesn't accept these as parameters. I'm planning to open this issue in jupyter/jupyter-js-services as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant