Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up stdio cache sizes for major reads #117

Open
nickalcock opened this issue Dec 11, 2024 · 1 comment
Open

Bump up stdio cache sizes for major reads #117

nickalcock opened this issue Dec 11, 2024 · 1 comment
Labels
performance items related to performance improvements

Comments

@nickalcock
Copy link
Member

(Reported by Leah Neukirchen.)

We routinely read some very large things on almost every invocation (available_filter_functions, kallmodsyms, module.ranges etc). We are doing all this with the default stdio buffer size, which is 1K. We should at least be using PAGE_SIZE: using more than that is risky for /proc but for stuff read out of /lib/modules etc we should probably go all the way to 64K.

This is a bit fiddly since it means we need to manage the stdio buffer lifetimes ourselves, so it's worth trying on one big one in /proc first to see if it has any effect. But it might well be worthwhile in the upcoming performance push.

@ezannoni
Copy link
Member

Wait until we have a better idea of where dtrace spends most of its time. We want to do this in a larger context of performance optimization in general.

@ezannoni ezannoni added the performance items related to performance improvements label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance items related to performance improvements
Projects
None yet
Development

No branches or pull requests

2 participants